Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move google release artifacts outside knative-releases/nightly #2696

Merged
merged 1 commit into from
Mar 8, 2021
Merged

Move google release artifacts outside knative-releases/nightly #2696

merged 1 commit into from
Mar 8, 2021

Conversation

MohamedElhawaty
Copy link
Contributor

Which issue(s) this PR fixes:
Fixes # knative/community#96

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 5, 2021
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 5, 2021
@MohamedElhawaty MohamedElhawaty changed the title Move google release artifacts outside knative-releases/nightly [WIP] Move google release artifacts outside knative-releases/nightly Mar 5, 2021
@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 5, 2021
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 5, 2021
@MohamedElhawaty MohamedElhawaty force-pushed the move-google-release-artifacts branch 2 times, most recently from b7bd648 to bb96796 Compare March 5, 2021 22:31
@MohamedElhawaty MohamedElhawaty changed the title [WIP] Move google release artifacts outside knative-releases/nightly Move google release artifacts outside knative-releases/nightly Mar 5, 2021
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 5, 2021
@MohamedElhawaty
Copy link
Contributor Author

/assign @nlopezgi

@chizhg
Copy link
Member

chizhg commented Mar 8, 2021

/approve
Leaving to @nlopezgi to apply lgtm

@knative-prow-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chizhg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2021
@nlopezgi
Copy link

nlopezgi commented Mar 8, 2021

/lgtm

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 8, 2021
@knative-prow-robot knative-prow-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 8, 2021
@MohamedElhawaty
Copy link
Contributor Author

Had to rebase to pull new release branches #2692

@nlopezgi
Copy link

nlopezgi commented Mar 8, 2021

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2021
@knative-prow-robot knative-prow-robot merged commit 72347e0 into knative:master Mar 8, 2021
@knative-prow-robot
Copy link
Collaborator

@MohamedElhawaty: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key config.yaml using file config/prod/prow/jobs/config.yaml

In response to this:

Which issue(s) this PR fixes:
Fixes # knative/community#96

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MohamedElhawaty MohamedElhawaty mentioned this pull request Mar 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nlopezgi nlopezgi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MohamedElhawaty @chizhg @knative-prow-robot @nlopezgi