Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

we only care about patch versions #3786

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented Apr 5, 2023

Dependabot bumped our 1.19 image to 1.20 which is something we don't want.

I'm hoping this change will mean we'll only bump respective patches

@knative-prow
Copy link

knative-prow bot commented Apr 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2023
@knative-prow knative-prow bot requested review from krsna-m and mgencur April 5, 2023 20:57
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 5, 2023
@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/knative-security.yaml:analyze-codeql. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@dprotaso
Copy link
Member Author

dprotaso commented Apr 5, 2023

/retest

@dprotaso
Copy link
Member Author

dprotaso commented Apr 6, 2023

/test unit-tests_test-infra_main

@krsna-m
Copy link
Contributor

krsna-m commented Apr 6, 2023

Do you have a link to the unwanted bump? I see 1305d23 this is most recent 1.19->1.20

@krsna-m
Copy link
Contributor

krsna-m commented Apr 6, 2023

initial behavior was to have a latest stable go version and manually bump older versions https://github.com/knative/test-infra/pull/3746/files#diff-3a809bc2ddb42dd8cd4627d729d61452cc1ed660a8d82ae02476cf740e7740faR242

1305d23 this broke that assumption.

I see the logic you want to implement though.

@krsna-m
Copy link
Contributor

krsna-m commented Apr 6, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2023
@knative-prow knative-prow bot merged commit ee656c8 into knative:main Apr 6, 2023
@dprotaso dprotaso deleted the dependabot-patch-only branch April 6, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants