Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix][s390x]:fixed the typo in configmap #3794

Merged
merged 2 commits into from
Apr 12, 2023
Merged

[fix][s390x]:fixed the typo in configmap #3794

merged 2 commits into from
Apr 12, 2023

Conversation

dilipgb
Copy link
Contributor

@dilipgb dilipgb commented Apr 12, 2023

This is the PR for s390x related prow job for kn-plugin-event. There was a typo in configmap for adjust.sh script.

@knative-prow knative-prow bot requested review from krsna-m and mgencur April 12, 2023 10:56
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 12, 2023
@dilipgb
Copy link
Contributor Author

dilipgb commented Apr 12, 2023

@upodroid can you please take a look at this PR. Thanks.

upodroid
upodroid approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2023
@knative-prow
Copy link

knative-prow bot commented Apr 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dilipgb, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2023
@knative-prow knative-prow bot merged commit f11329a into knative:main Apr 12, 2023
@knative-prow
Copy link

knative-prow bot commented Apr 12, 2023

@dilipgb: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key kn-plugin-event-main.gen.yaml using file prow/jobs/generated/knative-sandbox/kn-plugin-event-main.gen.yaml
  • key kn-plugin-event-release-1.7.gen.yaml using file prow/jobs/generated/knative-sandbox/kn-plugin-event-release-1.7.gen.yaml
  • key kn-plugin-event-release-1.8.gen.yaml using file prow/jobs/generated/knative-sandbox/kn-plugin-event-release-1.8.gen.yaml
  • key kn-plugin-event-release-1.9.gen.yaml using file prow/jobs/generated/knative-sandbox/kn-plugin-event-release-1.9.gen.yaml

In response to this:

This is the PR for s390x related prow job for kn-plugin-event. There was a typo in configmap for adjust.sh script.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upodroid upodroid upodroid approved these changes

@krsna-m krsna-m Awaiting requested review from krsna-m

@mgencur mgencur Awaiting requested review from mgencur

Assignees

@upodroid upodroid

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dilipgb @upodroid