Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env to knative/hack unit tests #3824

Merged
merged 2 commits into from
May 10, 2023
Merged

Add env to knative/hack unit tests #3824

merged 2 commits into from
May 10, 2023

Conversation

upodroid
Copy link
Member

@upodroid upodroid commented May 9, 2023

/cc @kvmware @cardil

This PR should fix the unbound variable error breaking the units tests in knative/hack#230

I also ran shfmt on the run_job.sh script.

@knative-prow knative-prow bot requested review from cardil and krsna-m May 9, 2023 20:38
@knative-prow
Copy link

knative-prow bot commented May 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 9, 2023
@krsna-m
Copy link
Contributor

krsna-m commented May 10, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2023
@knative-prow knative-prow bot merged commit aa55280 into knative:main May 10, 2023
12 checks passed
@knative-prow
Copy link

knative-prow bot commented May 10, 2023

@upodroid: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key hack-main.gen.yaml using file prow/jobs/generated/knative/hack-main.gen.yaml

In response to this:

/cc @kvmware @cardil

This PR should fix the unbound variable error breaking the units tests in knative/hack#230

I also ran shfmt on the run_job.sh script.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants