Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Point to correct slack channels #3829

Merged
merged 1 commit into from
May 17, 2023
Merged

Point to correct slack channels #3829

merged 1 commit into from
May 17, 2023

Conversation

krsna-m
Copy link
Contributor

@krsna-m krsna-m commented May 17, 2023

@knative-prow knative-prow bot added area/tools Issues or PRs related to internal tools found at /tools approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 17, 2023
@knative-prow knative-prow bot requested review from cardil and psschwei May 17, 2023 13:55
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 17, 2023
@krsna-m krsna-m requested review from upodroid and removed request for psschwei May 17, 2023 13:55
upodroid
upodroid approved these changes May 17, 2023
View reviewed changes
Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed this.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2023
@knative-prow
Copy link

knative-prow bot commented May 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kvmware, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@upodroid
Copy link
Member

known flake

/test pull-knative-test-infra-prow-tests-image-build

@knative-prow knative-prow bot merged commit 628d995 into knative:main May 17, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upodroid upodroid upodroid approved these changes

@cardil cardil Awaiting requested review from cardil

Assignees

@upodroid upodroid

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/tools Issues or PRs related to internal tools found at /tools lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@krsna-m @upodroid