Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the example config to example.config.json #41

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TheToddLuci0
Copy link
Contributor

Avoid potential issues with people putting their actual secrets into a file tracked by git.

config.json is already in .gitignore, so should be good there.

@knavesec
Copy link
Owner

knavesec commented Aug 2, 2023

Ehh, I think there's always going to be issues with people putting creds in files. Even with a name change, it's still just as easy for users to put their secrets in the example.config.json file and never rename it, which defeats the purpose

@knavesec
Copy link
Owner

knavesec commented Aug 2, 2023

Unless others have strong opinions on this, I plan on just keeping it the way it is. I usually just have a duplicate json file active.config.json or something similar that I use

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants