Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signing still broken. Also, retries fail if retry condition is not explicitly defined. #103

Closed
willvincent opened this issue Oct 20, 2020 · 1 comment

Comments

@willvincent
Copy link
Contributor

Since other issues on the subject have been closed, despite still being an issue...

Signing fails if retries are enabled, after v0.2.17

The cause of this, is that the alternate retry logic does not properly utilize the signed request payload, causing a signature mismatch.

My PR #102 resolves this, and additionally handles the scenario where retries are defined, but no retryCondition is defined in the config, which given it's 'optional' status should naturally fallback to utilize the default axios-retry condition -- which is does with this PR.

@kndt84
Copy link
Owner

kndt84 commented Dec 10, 2020

Thanks for sending a PR. I've merged it.

@kndt84 kndt84 closed this as completed Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants