Flatten all the editing methods into DAG
#34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kneasle
force-pushed
the
edit-method-cleanup
branch
5 times, most recently
from
37cb13b
to
3ca0d35
Compare
kneasle
commented
Dec 7, 2020
kneasle
commented
Dec 7, 2020
|
@Kixunil, what do you think of this? I think most of the stuff has been pretty good and feels much better, except the things I've flagged up - this still took me most of yesterday, though 😆. |
Kixunil
reviewed
Dec 8, 2020
Closed
kneasle
force-pushed
the
edit-method-cleanup
branch
2 times, most recently
from
12c3b88
to
48a937e
Compare
kneasle
force-pushed
the
edit-method-cleanup
branch
from
04fa3bc
to
fdac6ea
Compare
|
Right I think in the interests of letting other stuff happen and not generate merge conflicts, I think we should merge this. I fixed a very rogue crash bug that had been introduced earlier, but it's seeming pretty stable now. We could do with some integration tests, but that's for another PR I reckon. @Kixunil, what do you think? |
kneasle
force-pushed
the
edit-method-cleanup
branch
from
fdac6ea
to
393df72
Compare
|
Sounds good. We can always refactor more later. Doing it in chunks is better anyway. |
kneasle
force-pushed
the
edit-method-cleanup
branch
from
393df72
to
1609ffd
Compare
|
Coool! Done another rebase to fix merge conflicts, now merging... |
kneasle
added a commit
that referenced
this pull request
Dec 10, 2020
After #34, inserting into JSON objects is now possible. This is now reflected in the README.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #24.
TODO:
CannotInsertIntoandCannotReplacewith something likeInvalidChild