Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add trait NodeClass, struct Class #71

Merged
merged 1 commit into from Jan 12, 2021
Merged

add trait NodeClass, struct Class #71

merged 1 commit into from Jan 12, 2021

Conversation

stokhos
Copy link
Contributor

@stokhos stokhos commented Jan 9, 2021 •
edited

fixes #63 and fixes #68

  1. Add NodeClass, and Class to Ast.
  2. Add EditErr::CannotBeRoot, minor change to EditErr::CannotBeRoot
  3. Now dag validate char first

kneasle
kneasle reviewed Jan 10, 2021
View reviewed changes
Copy link
Owner

@kneasle kneasle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally looks very solid, with just small tweaks to make it better.

src/ast/json.rs Outdated Show resolved Hide resolved
src/ast/json.rs Outdated Show resolved Hide resolved
src/ast/json.rs Outdated Show resolved Hide resolved
src/ast/json.rs Outdated Show resolved Hide resolved
src/ast/json.rs Outdated Show resolved Hide resolved
src/ast/mod.rs Outdated Show resolved Hide resolved
src/ast/mod.rs Outdated Show resolved Hide resolved
src/editor/dag.rs Outdated Show resolved Hide resolved
src/editor/dag.rs Show resolved Hide resolved
@stokhos stokhos requested a review from kneasle January 10, 2021 20:53
@stokhos stokhos marked this pull request as draft January 10, 2021 20:59
@stokhos stokhos marked this pull request as ready for review January 10, 2021 21:35
@stokhos
add trait NodeClass, struct Class, and make EditResult to use NodeCla…
c28899c 
…ss and Class

minor fix

changed EditResult to use Class

 fixed doc
kneasle
kneasle approved these changes Jan 12, 2021
View reviewed changes
Copy link
Owner

@kneasle kneasle left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Merging now...

@kneasle kneasle merged commit 497e16c into kneasle:master Jan 12, 2021
@kneasle kneasle mentioned this pull request Jan 12, 2021
Closed
@stokhos stokhos deleted the type_safe_intermediate branch January 13, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kneasle kneasle kneasle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash when insert an invalid char in array, and object Add type-safe intermediate step for node names
2 participants
@stokhos @kneasle