Implement counts #80
Merged
Implement counts #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately I don't have a lot of time lately. I may be able to look at it during weekend, not sure. |
|
It's fine - don't stress yourself over it. Most of it is of the janky-but-works type of code, but it'll be refactored into cleaner code along with other things... |
|
I think in the interest of avoiding mega-big merge conflicts, I'm gonna merge this this evening. If you happen to have a sudden desire to review ~1k lines of code then now is the time 馃榿. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements counts in two places:
o3tinserting 3trues as children of the cursor3uto jump back 3 undo levels@Kixunil, if you have the time to review this much code then that would be awesome - but there are plenty of unit tests for the changes (and I want to simplify them in future), so if you don't then that's fine.
Edit: This PR is wayyyy bigger than I thought it would be 馃槅. Perhaps moving all the unit tests around wasn't the best idea... but it's done now.