Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support example html in comments and add API to access to Section #77

Closed
wants to merge 4 commits into from

Conversation

briansloane
Copy link

I forked kss from @mkdynamic and merged with the latest master from the https://github.com/kneath/kss repo. This PR contains the updates that there were part of #56 that allowed for putting example html in the comments as follows:

// A basic button.
//
// :hover    - The hover state
// :active   - The pressed state
// :disabled - The disabled state
//
// <button class="m-btn $modifier-class">Button</button>
//
// Styleguide 1.1

@benschwarz
Copy link
Collaborator

@briansloane Do you think you'd be able to update the readme and spec pages accordingly?
Eg: Example markup can only be one line. Etc

@briansloane
Copy link
Author

@benschwarz Sure. I'll get those updated and add to the PR.

@briansloane
Copy link
Author

@benschwarz I've updated the readme and spec accordingly. Let me know if you have any other questions.

@benschwarz
Copy link
Collaborator

Ok, I think you've won me over too.

Single line HTML would work (but who ever does anything with a single element?) — so it feels like a feature that would leave you wanting more (multi-line HTML, which would be weird).

Thanks for your efforts on this @briansloane, sorry we won't be accepting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants