Document optimizer hints #306
Conversation
components/Sidebar.jsx
Outdated
| @@ -138,6 +138,7 @@ export default class Sidebar extends Component { | |||
| <li>– <a href="#Builder-avg">avg</a></li> | |||
| <li>– <a href="#Builder-increment">increment</a></li> | |||
| <li>– <a href="#Builder-decrement">decrement</a></li> | |||
| <li>– <a href="#Builder-optimizerHint">optimizerHint</a></li> | |||
There was a problem hiding this comment.
I'm not sure about the order where to put the method
There was a problem hiding this comment.
I think the place is fine.
sections/builder.js
Outdated
| { | ||
| type: "runnable", | ||
| content: ` | ||
| knex('accounts').where('userid', '=', 1).optimizerHint('hint()') |
There was a problem hiding this comment.
runnable won't work before the change is released, as the scipt cant compile the query on the current knex version
There was a problem hiding this comment.
Can you use a real hint in the example?
There was a problem hiding this comment.
@kibertoad Added real MySQL hint example 7bc4df5
sections/builder.js
Outdated
| { | ||
| type: "method", | ||
| method: "optimizerHint", | ||
| example: ".optimizerHint(hint)", |
There was a problem hiding this comment.
Do you have a convention how to denote that hint may be either a single value or an array of values?
There was a problem hiding this comment.
Like this:
.whereIn(column|columns, array|callback|builder)
There was a problem hiding this comment.
@kibertoad Ok. Used hint|hints c12ab97
Documents knex/knex#4199 and PR knex/knex#4243