Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds documentation about how to group and order inputs to a union #500

Merged
merged 2 commits into from
Mar 29, 2023

Conversation

j23schoen
Copy link
Contributor

@j23schoen j23schoen commented Mar 8, 2023

Issues about this here:
knex/knex#739
knex/knex#913

Here's the PR that addressed it:
knex/knex#5030

This documentation should make it clear how to apply the following clauses to inputs of the union:

  • group
  • having
  • order
  • limit
  • offset

I'm open to some wording adjustments to fit better with the theme of the knex docs, but I hope I've conveyed the issue and solution

@CodingItWrong
Copy link

I'd find this change helpful. Without this I would assume I can just chain order, limit etc onto the previous statements as shown in the documentation. Would save me a lot of confusion.

Copy link
Collaborator

@OlivierCavadenti OlivierCavadenti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@OlivierCavadenti OlivierCavadenti merged commit 64fb10d into knex:main Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants