Skip to content

Commit

Permalink
fix(typings): table builder some methods return wrong types (#4764)
Browse files Browse the repository at this point in the history
Co-authored-by: maximelkin <maxeljkin@gmail.com>
  • Loading branch information
maximelkin and maximelkin committed Oct 23, 2021
1 parent e991090 commit 58de7a9
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions types/index.d.ts
Expand Up @@ -1914,7 +1914,7 @@ export declare namespace Knex {
): ColumnBuilder;
dropColumn(columnName: string): TableBuilder;
dropColumns(...columnNames: string[]): TableBuilder;
renameColumn(from: string, to: string): ColumnBuilder;
renameColumn(from: string, to: string): TableBuilder;
integer(columnName: string, length?: number): ColumnBuilder;
tinyint(columnName: string, length?: number): ColumnBuilder;
bigInteger(columnName: string): ColumnBuilder;
Expand Down Expand Up @@ -1946,7 +1946,7 @@ export declare namespace Knex {
timestamps(
useTimestampType?: boolean,
makeDefaultNow?: boolean
): ColumnBuilder;
): void;
binary(columnName: string, length?: number): ColumnBuilder;
enum(
columnName: string,
Expand All @@ -1961,7 +1961,7 @@ export declare namespace Knex {
json(columnName: string): ColumnBuilder;
jsonb(columnName: string): ColumnBuilder;
uuid(columnName: string): ColumnBuilder;
comment(val: string): TableBuilder;
comment(val: string): void;
specificType(columnName: string, type: string): ColumnBuilder;
primary(columnNames: readonly string[], options?: Readonly<{constraintName?: string, deferrable?: deferrableType}>): TableBuilder;
/** @deprecated */
Expand All @@ -1985,7 +1985,7 @@ export declare namespace Knex {
dropUnique(columnNames: readonly (string | Raw)[], indexName?: string): TableBuilder;
dropPrimary(constraintName?: string): TableBuilder;
dropIndex(columnNames: string | readonly (string | Raw)[], indexName?: string): TableBuilder;
dropTimestamps(): ColumnBuilder;
dropTimestamps(): TableBuilder;
queryContext(context: any): TableBuilder;
}

Expand Down

0 comments on commit 58de7a9

Please sign in to comment.