fix: escapeObject parameter order for Postgres dialect. (#2003)

* fix: escapeObject parameter order for Postgres dialect. * test: escapeObject for Postgres dialect.
knex · Apr 12, 2017 · 5c0b193 · 5c0b193
1 parent a5f4c39
commit 5c0b193
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/dialects/postgres/index.js b/src/dialects/postgres/index.js
@@ -78,7 +78,7 @@ assign(Client_PG.prototype, {
       }
       return escaped
     },
-    escapeObject(val, timezone, prepareValue, seen = []) {
+    escapeObject(val, prepareValue, timezone, seen = []) {
       if (val && typeof val.toPostgres === 'function') {
         seen = seen || [];
         if (seen.indexOf(val) !== -1) {

diff --git a/test/unit/query/builder.js b/test/unit/query/builder.js
@@ -4182,4 +4182,13 @@ describe("QueryBuilder", function() {
     });
   })
 
+  it('#2003, properly escapes objects with toPostgres specialization', function () {
+    function TestObject() { }
+    TestObject.prototype.toPostgres = function() {
+      return 'foobar'
+    }
+    testquery(qb().table('sometable').insert({ id: new TestObject() }), {
+      postgres: "insert into \"sometable\" (\"id\") values ('foobar')"
+    });
+  })
 });