Skip to content

Commit

Permalink
Merge pull request #1 from serprex/fix-typings
Browse files Browse the repository at this point in the history
Fixed JoinRaw, RawQueryBuilder and RawBuilder interfaces.
  • Loading branch information
extern-c committed Jan 4, 2019
2 parents e76c4e4 + d7cdb35 commit a49b4c1
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions types/knex.d.ts
Expand Up @@ -2,7 +2,7 @@
// -----
// Originally based on contributions to DefinitelyTyped:
// Definitions by: Qubo <https://github.com/tkQubo>
// Pablo Rodríguez <https://github.com/MeLlamoPablo>
// Pablo Rodríguez <https://github.com/MeLlamoPablo>
// Matt R. Wilson <https://github.com/mastermatt>
// Satana Charuwichitratana <https://github.com/micksatana>
// Shrey Jain <https://github.com/shreyjain1994>
Expand Down Expand Up @@ -307,7 +307,7 @@ declare namespace Knex {
}

interface JoinRaw {
(tableName: string, binding?: ValueMap): QueryBuilder;
(tableName: string, binding?: Value | ValueMap): QueryBuilder;
}

interface With extends WithRaw, WithWrapped {}
Expand Down Expand Up @@ -423,8 +423,8 @@ declare namespace Knex {
}

interface RawQueryBuilder {
(sql: string, ...bindings: (ValueMap | QueryBuilder)[]): QueryBuilder;
(sql: string, bindings: (ValueMap | QueryBuilder)[] | ValueMap): QueryBuilder;
(sql: string, ...bindings: (Value | QueryBuilder)[]): QueryBuilder;
(sql: string, bindings: (Value | QueryBuilder)[] | ValueMap): QueryBuilder;
(raw: Raw): QueryBuilder;
}

Expand All @@ -437,8 +437,8 @@ declare namespace Knex {

interface RawBuilder {
(value: Value): Raw;
(sql: string, ...bindings: (ValueMap | QueryBuilder)[]): Raw;
(sql: string, bindings: (ValueMap | QueryBuilder)[] | ValueMap): Raw;
(sql: string, ...bindings: (Value | QueryBuilder)[]): Raw;
(sql: string, bindings: (Value | QueryBuilder)[] | ValueMap): Raw;
}

//
Expand Down

0 comments on commit a49b4c1

Please sign in to comment.