pin typescript for node 12

knex · Jul 4, 2023 · bd9e97b · bd9e97b
1 parent 1fac563
commit bd9e97b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/.github/workflows/integration-tests.yml b/.github/workflows/integration-tests.yml
@@ -46,6 +46,11 @@ jobs:
               "${{ matrix.database-type }}"
         if: matrix.database-type != 'sqlite3' && matrix.database-type != 'better-sqlite3'
 
+      # https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-1.html#es2020-and-nodejs-1417-as-minimum-runtime-requirements
+      - name: Run npm install typescript@5.0.4 if Node 12.x
+        run: npm install typescript@5.0.4
+        if: matrix.node-version == '12.x'
+
       - name: Run npm install
         run: npm install
 
@@ -112,7 +117,7 @@ jobs:
         with:
           always-auth: false
           node-version: ${{ matrix.node-version }}
-      
+
       - name: Test npm git dependency
         shell: bash
         run: |

diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml
@@ -34,13 +34,13 @@ jobs:
           always-auth: false
           node-version: ${{ matrix.node-version }}
 
+      - name: Run npm install mysql2@3.2.0 and typescript@5.0.4 if Node 12.x
+        run: npm install mysql2@3.2.0 typescript@5.0.4
+        if: matrix.node-version == '12.x'
+
       - name: Run npm install
         run: npm install
 
-      - name: Run npm install mysql2@3.2.0 if Node 12.x
-        run: npm install mysql2@3.2.0
-        if: matrix.node-version == '12.x'
-
       - run: npm run build
 
       - name: Run Tests