Adding support for specifying a DATABASE_URL without a password #1473
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier today I found that Knex was not parsing a
user
from the followingDATABASE_URL
:This was because the URL was missing a password. Because
pg-connection-string
is being used for Postgres connections, this already worked for Postgres URLs. If you want a laugh, feel free to look at my commits from earlier today where I clearly had no idea how I'd broken all our Travis tests by starting to useDATABASE_URL
.PS: Knex is awesome, thanks for all the work on this project.