Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Respect the knexfile stub option while generating a migration #3337

Merged
merged 3 commits into from Jul 10, 2019
Merged

fix: Respect the knexfile stub option while generating a migration #3337

merged 3 commits into from Jul 10, 2019

Conversation

bohdan-shulha
Copy link
Contributor

@bohdan-shulha bohdan-shulha commented Jul 7, 2019 •
edited by kibertoad

fixes #3333

@bohdan-shulha bohdan-shulha mentioned this pull request Jul 7, 2019
Closed
@kibertoad
Copy link
Collaborator

Thanks! Could you please add test in https://github.com/tgriesser/knex/blob/master/test/cli/migrate-make.spec.js for this case?

@kibertoad kibertoad merged commit c6481e8 into knex:master Jul 10, 2019
@bohdan-shulha
Copy link
Contributor Author

@kibertoad , thanks for the tests and the release, I had no time this week to implement test cases

felixmosh pushed a commit to felixmosh/knex that referenced this pull request Jul 13, 2019
@felixmosh
fix: Respect the knexfile stub option while generating a migration (k…
a60cdd3 
…nex#3337)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom migration stubs are not used
2 participants
@bohdan-shulha @kibertoad