Fix queryContext function defintion

[andrewburgess]

According to the docs, calling queryContext with no arguments returns the context object. (ref: https://knexjs.org/#Builder-queryContext)

This PR adds the relevant overload to the function definition for that use case.

[kibertoad]

Thanks! Could you also update https://github.com/knex/knex/blob/master/types/test.ts?

[kibertoad]

would it be better defined as Record<string, any>?

[andrewburgess]

I'm not sure, would that be for the return type?

From what I can tell it returns exactly what was put in when called with an argument, so I figured it would be best to just have those types match

[kibertoad]

ok, fair :). does it work correctly if user passes e. g. string?

[andrewburgess]

Yep, this is the underlying implementation:

knex/lib/helpers.js

Lines 79 to 85 in 988fb24

	Target.prototype.queryContext = function(context) {
	if (isUndefined(context)) {
	return this._queryContext;
	}
	this._queryContext = context;
	return this;
	};

And the docs say the queryContext is shallowly cloned when a query builder is cloned:

knex/lib/query/builder.js

Line 93 in f87b28c

cloned._queryContext = clone(this._queryContext);

which uses lodash.clone and should work on any value passed in

[andrewburgess]

Thanks! Could you also update https://github.com/knex/knex/blob/master/types/test.ts?

Can do

[kibertoad]

thanks!

[kibertoad]

Released in 0.20.4