Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove peerDependencies and keep peerDependenciesMeta only. #4437

Closed
boostbob opened this issue Apr 15, 2021 · 1 comment · Fixed by #4480
Closed

remove peerDependencies and keep peerDependenciesMeta only. #4437

boostbob opened this issue Apr 15, 2021 · 1 comment · Fixed by #4480

Comments

@boostbob
Copy link

boostbob commented Apr 15, 2021 •
edited
Loading

The npm v7 will install peerDependencies automaticly, it will install mysql,mysql2,pg,sqlite3,tedious, so just keep peerDependenciesMeta will be suitable.

ref https://github.com/sequelize/sequelize/blob/main/package.json#L95
@kibertoad
Copy link
Collaborator

Any chance you could provide PR for this?

@kibertoad kibertoad mentioned this issue May 11, 2021
Merged
@kibertoad kibertoad mentioned this issue Aug 22, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove peerDependencies to avoid auto-install on npm 7 knex/knex
2 participants
@boostbob @kibertoad