Make view.columns() functionality optional when creating a view

[bakasmarius]

Environment

Knex version: 0.95.14
Database + version: PostgreSQL 13.4
OS: Windows10

Feature discussion / request

As a PostgreSQL user, I would like to be able to create such queries for views:
create view "users_view" as select "users".*, "user_roles"."role_code" from "users" inner join "user_roles" on "users"."user_id" = "user_roles"."user_id"

I could achieve it this with this code:

knex.schema.createView('users_view', (view) => {
    view.as(knex('users').join('user_roles', 'users.user_id', 'user_roles.user_id').select('users.*', 'user_roles.role_code'))
  })

But currently this doesn't work because I didn't use view.columns() functionality, so knex throws columns is not iterable error.

I edited the knex\lib\schema\viewcompiler.js file, changed part of createQuery code like this and everything worked as I wanted:

    const formatColumnsArr = [];
    for (const c of columns || []) {
      formatColumnsArr.push(
        columnize_(c, this.viewBuilder, this.client, this.bindingsHolder)
      );
    }
    const formatColumns = formatColumnsArr.length ? ' (' + formatColumnsArr.join(', ') + ')' : ''
    let sql = createStatement + this.viewName() + formatColumns;

I would be happy to provide a PR if this is something you would like.

[OlivierCavadenti]

I would be happy to provide a PR if this is something you would like.

Please do, views without columns are standard (it will be optional in the code like you write).

[thebrownfox]

@OlivierCavadenti when is this going to be released?

[kibertoad]

@thefoxie Would RC release work for you?

[thebrownfox]

@kibertoad yeah sure :)

[kibertoad]

I'll publish 1.0.0-next1 tonight then.

[kibertoad]

Released in 1.0.1.