Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toString should quote and possibly escape #59

Closed
moll opened this issue Sep 10, 2013 · 1 comment
Closed

toString should quote and possibly escape #59

moll opened this issue Sep 10, 2013 · 1 comment
Labels
feature request

Comments

@moll
Copy link
Contributor

moll commented Sep 10, 2013

Hey,

I was writing a few tests and initially freaked out because the output of toString has no quotes around user supplied data. I realize Knex uses the database's own query parameters, but perhaps making toString match reality would be reasonable and helpful.
@tgriesser
Copy link
Member

Yeah, definitely, planning this for the 0.4.0 - hooking into each db lib's escape functionality if possible, if not (sqlite3 does it in the binary) hopefully providing something close in js.

elliotf pushed a commit to elliotf/knex that referenced this issue Nov 24, 2014
@tgriesser
attach and detach add and remove models from collection, knex#59
0b8fed3
JakobJoonas pushed a commit to JakobJoonas/knex that referenced this issue Sep 23, 2022
@elhigu
Added link to afterCreate to sidebar (knex#59)
3c238ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tgriesser @moll