Skip to content

/ knex

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.limit(0) not limiting to empty array #655

Closed
leore opened this issue Jan 31, 2015 · 4 comments
Closed

.limit(0) not limiting to empty array #655

leore opened this issue Jan 31, 2015 · 4 comments

Comments

@leore
Copy link

@leore leore commented Jan 31, 2015

When I do .limit(0) I end up getting the entire dataset back. 0.6.* did not have this behaviour
@vschoettke
Copy link
Collaborator

@vschoettke vschoettke commented Jan 31, 2015

Duplicate of #585. This is already fixed in the repo but yet not published to npm.

Just out of curiosity, why do you want to execute limit(0) query?
@vschoettke vschoettke closed this Jan 31, 2015
@leore
Copy link
Author

@leore leore commented Jan 31, 2015

We have an API that takes count and offset as query parameters. Our users and apps that consume this api have corner cases where they pass in count=0 and expect to get an empty array not the full data set.
@leore
Copy link
Author

@leore leore commented Feb 2, 2015

When do you think #585 will be published to npm?
@tgriesser
Copy link
Member

@tgriesser tgriesser commented Feb 2, 2015

Ah sorry abt. that... I'll do a quick pass through and try and get a release out today
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@tgriesser @leore @vschoettke