Fixed knex #1577 #1578
Merged
Fixed knex #1577 #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aslo corrected tests for primarykey
Update local version to current master
|
Oh, don't matter about 3 commits "Fix for installing from github". It do nothing to code. Have no idea why they are listed for this PR, I thought I've added them later. |
| }).toSQL(); | ||
|
|
||
| equal(1, tableSql.length); | ||
| expect(tableSql[0].sql).to.equal('ALTER TABLE [users] DROP PRIMARY KEY'); | ||
| expect(tableSql[0].sql).to.equal('ALTER TABLE [users] DROP CONSTRAINT [testconstraintname]'); |
There was a problem hiding this comment.
Is DROP PRIMARY not supported by MSSQL?
There was a problem hiding this comment.
Yep, DROP CONSTRAINT only. See this article, section "Using Transact-SQL"
https://msdn.microsoft.com/en-us/library/ms190621.aspx
|
@statyan Looks good, I don't know much about MSSQL, but I'll cross reference these changes with the docs in future. Would you be able to squash these commits into one please? |
|
Ok,I'll try do it! |
|
@rhys-vdw when you click "merge pull request" button there is option to do squash merge if one likes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix an issue with
dropPrimaryfor MSSQL and fix test for primary key - now column test2 is set to notNullable. Without it primarykey test fails 'cause nullable column can't be set for primary key.