Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support using dependency straight from git repository #1708

Merged
merged 1 commit into from Oct 9, 2016
Merged

Support using dependency straight from git repository #1708

merged 1 commit into from Oct 9, 2016

Conversation

vellotis
Copy link
Contributor

@vellotis vellotis commented Sep 29, 2016 •
edited

Support using knex as a dependency from git without having to perform extra npm install & npm run build configuration.

Using build.js from Bookshelf https://github.com/tgriesser/bookshelf/blob/8ae37faeecfb73bc6a55672e4487202061421c74/scripts/build.js

Closes #1180

@vellotis
Copy link
Contributor Author

vellotis commented Oct 7, 2016

@tgriesser ping

@tgriesser tgriesser merged commit 7a04de4 into knex:master Oct 9, 2016
@tgriesser
Copy link
Member

Nice, thanks!

tgriesser added a commit that referenced this pull request Oct 10, 2016
@tgriesser
Merge branch 'master' into refactor
dea7889 
* master:
  Fix test suite for node 0.12
  Fix test suite for node 0.12
  More cleanup for #1725
  Support using dependency straight from git repository (#1708)
  Maybe fix #1725?
  Fix test for acquireConnectionTimeout
  More test suite fixes
  Fix test in 0.12
@tgriesser tgriesser mentioned this pull request Oct 19, 2016
Closed
rslabbert pushed a commit to rslabbert/knex that referenced this pull request Nov 9, 2016
@vellotis
Support using dependency straight from git repository (knex#1708)
44203ab 
Using build.js from Bookshelf https://github.com/tgriesser/bookshelf/blob/8ae37faeecfb73bc6a55672e4487202061421c74/scripts/build.js
@wolfgang42 wolfgang42 mentioned this pull request Sep 20, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vellotis @tgriesser