Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration transaction #1962

Merged
merged 13 commits into from Mar 27, 2017
Merged

Migration transaction #1962

merged 13 commits into from Mar 27, 2017

Commits on Mar 11, 2017

  1. Use transaction for entire migration batch + locking if all migration… 

    …s are transactional.
    @itaysabato
    itaysabato committed Mar 11, 2017
    Copy the full SHA
    e3ab8a8 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2017

  1. Fix tests. 

    Use knex instead of query builder.
Do no use single transaction if `disableTransactions` is true.
    @itaysabato
    itaysabato committed Mar 12, 2017
    Copy the full SHA
    a0da3c8 View commit details
    Browse the repository at this point in the history

  2. Added tests for parallel migrations. 

    Subtract already done migrations after getting the lock, when there is a wrapping transaction.
    @itaysabato
    itaysabato committed Mar 12, 2017
    Copy the full SHA
    abb0e8b View commit details
    Browse the repository at this point in the history

  3. Fix indentation.

    @itaysabato
    itaysabato committed Mar 12, 2017
    Copy the full SHA
    19eca7a View commit details
    Browse the repository at this point in the history

  4. Fix linting errors (which are locally warnings, for some reason).

    @itaysabato
    itaysabato committed Mar 12, 2017
    Copy the full SHA
    9cec9e1 View commit details
    Browse the repository at this point in the history

  5. Remove const keyword. 

    Remove obsolete `it` clauses.
    @itaysabato
    itaysabato committed Mar 12, 2017
    Copy the full SHA
    94829f9 View commit details
    Browse the repository at this point in the history

  6. No maria. PG first.

    @itaysabato
    itaysabato committed Mar 12, 2017
    Copy the full SHA
    6c24a44 View commit details
    Browse the repository at this point in the history

  7. Test only pg and oracle.

    @itaysabato
    itaysabato committed Mar 12, 2017
    Copy the full SHA
    3ddd571 View commit details
    Browse the repository at this point in the history

  8. Remove error swallowing.

    @itaysabato
    itaysabato committed Mar 12, 2017
    Copy the full SHA
    adf4985 View commit details
    Browse the repository at this point in the history

  9. Test parallel migration only in postgres (select for update works dif… 

    …ferently in other databases).
    @itaysabato
    itaysabato committed Mar 12, 2017
    Copy the full SHA
    3ed2056 View commit details
    Browse the repository at this point in the history

  10. Add transaction to missed places.

    @itaysabato
    itaysabato committed Mar 12, 2017
    Copy the full SHA
    5ba17df View commit details
    Browse the repository at this point in the history

  11. Remove ignored table name argument.

    @itaysabato
    itaysabato committed Mar 12, 2017
    Copy the full SHA
    19c298c View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2017

  1. Enabled parallel migrations test for mssql dialect (still not part … 

    …of CI test).

Fixed indentation.
    @itaysabato
    itaysabato committed Mar 27, 2017
    Copy the full SHA
    6675dc1 View commit details
    Browse the repository at this point in the history