Add fetchAsString optional parameter to oracledb dialect

[atiertant]

add fetchAsString parameter (see https://github.com/oracle/node-oracledb/blob/master/doc/api.md#propdbfetchasstring)

var knex = require('knex')({
  client: 'oracledb',
  connection: {
    host : '127.0.0.1',
    user : 'your_database_user',
    password : 'your_database_password',
    database : 'myapp_test'
  }
  fetchAsString: ['DATE', 'NUMBER', 'CLOB']
});

[elhigu]

Looks fine except that it should validate input strings and include test and documentation.

[elhigu]

It would be better to just return promise from function instead of calling done in various places.

[elhigu]

destroying client here makes all of these tests dependent to each other... sadly thats pretty much how all tests of knex are written.

[atiertant]

could make two describe creating client in before and destroy in after.

[elhigu]

that would be more clean

[elhigu]

Generally tests and docs looks good. Only thing is that I don't like using done() callback in tests without a good reason, they are more error prone than just returning a promise for test hook.

[elhigu]

not necessary done parameter

[elhigu]

not necesssary done()

[elhigu]

why this timeout is here?

[elhigu]

Sorry for taking ages with this. I found still couple of minor issues from the code. And probably that timeout should be just removed or use some value that is relative to process.env.KNEX_TEST_TIMEOUT.

[atiertant]

@elhigu timeout was usefull on local only and we removed unnecessary done parameter.

[elhigu]

Now it looks perfect, thanks!

[elhigu]

I'll try to roll out knex 0.13 during this weekend

[atiertant]

@elhigu that's a good news ! thanks