Add unit tests for table comment #2098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elhigu
reviewed
Jun 9, 2017
test/unit/schema/oracle.js
Outdated
| expect(tableSql[0].sql).to.equal('comment on table "users" is \'\''); | ||
| }); | ||
|
|
||
| it('test set empty comment using null', function() { |
There was a problem hiding this comment.
I wouldn't consider setting comment to be empty string by setting it to null or undefined as a intended behaviour. So better to not add test for that functionality, since better test would be throwing an error because of invalid parameter.
elhigu
requested changes
Jun 9, 2017
There was a problem hiding this comment.
Thanks for tests! They look fine, except that none of the dialects should have tests that .comment with undefined / null / falsy param sets empty string comment. Invalid parameters should throw an error (any parameter that is not string).
So please delete those tests setting comments with non-string arguments and I can merge this.
izri16
force-pushed
the
add-table-comment-tests
branch
from
72e0ef8
to
97cef1d
Compare
|
Ok I deleted those non-string args tests and rebased. |
* Tests for setting comment on table for postgresql, mysql and oracle * No tests for sqlite as it does not seem to support comments * No tests for mssql as it can not be tested simply using sql comparison
izri16
force-pushed
the
add-table-comment-tests
branch
from
97cef1d
to
5ecef24
Compare
elhigu
approved these changes
Jun 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created tests to add table comment. These are for postgresql, mysql and oracle as it seems to me that
.comment()function is not supported for sqlite.I test setting the comment and setting it back to empty string. I assume that many users will expect that
.comment(null)or simply.comment()will work the same as.comment('')I also made tests for these cases. However.comment(null)and.comment()does not work that way in mysql so these tests are only for postgresql and oracle.