Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrectly set UV_THREADPOOL_SIZE #2372

Merged
merged 1 commit into from Dec 8, 2017
Merged

Incorrectly set UV_THREADPOOL_SIZE #2372

merged 1 commit into from Dec 8, 2017

Conversation

tomulin1
Copy link
Contributor

@tomulin1 tomulin1 commented Dec 8, 2017

Incorrectly set UV_THREADPOOL_SIZE when passed from system variables. It's recognized as string (windows).

Incorrectly set UV_THREADPOOL_SIZE when passed from system variables. It's recognized as string (windows).
@elhigu
Copy link
Member

@elhigu elhigu commented Dec 8, 2017

Thanks! I believe that code is working wrong on every platform. I'll merge this after getting last tests run.

@elhigu elhigu merged commit 5e12b23 into knex:master Dec 8, 2017
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants