Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'ref' function #2509

Merged
merged 3 commits into from May 2, 2018
Merged

Added 'ref' function #2509

merged 3 commits into from May 2, 2018

Conversation

@wubzz
Copy link
Member

@wubzz wubzz commented Feb 23, 2018

This a dead simple implementation of #2507 which could definitely be improved upon. (Which I'm more than open for)

Can write more tests and write docs once design and featureset has been finalized.

@wubzz wubzz requested review from tgriesser and elhigu Feb 23, 2018
@wubzz
Copy link
Member Author

@wubzz wubzz commented Feb 23, 2018

Maybe support for aliases..?

Copy link
Member

@elhigu elhigu left a comment

Looks good! Only missing documentation.

@wubzz
Copy link
Member Author

@wubzz wubzz commented Apr 30, 2018

@elhigu elhigu merged commit e724066 into knex:master May 2, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@elhigu
Copy link
Member

@elhigu elhigu commented May 2, 2018

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants