Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make using v8flags package optional #2643

Closed
wants to merge 1 commit into from
Closed

Make using v8flags package optional #2643

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 12 additions & 2 deletions bin/cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,10 +319,20 @@ function invoke(env) {
});
}

const cli = new Liftoff({
let v8flags;

if (typeof process.env.KNEX_V8_FLAGS !== 'undefined') {
v8flags = process.env.KNEX_V8_FLAGS.split(' ').filter(function(flag) {
return flag;
});
} else {
v8flags = require('v8flags');
}

var cli = new Liftoff({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be const

name: 'knex',
extensions: interpret.jsVariants,
v8flags: require('v8flags'),
v8flags: v8flags,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be just v8flags

});

cli.on('require', function(name) {
Expand Down