Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added onVal, andOnVal, orOnVal to JoinClause #2745

Closed
wants to merge 1 commit into from

Conversation

wubzz
Copy link
Member

@wubzz wubzz commented Aug 1, 2018

Relates to #2707 - See discussion

Allows join using parameters instead of having to rely on Raw.

Before

this.on('p.id', '=', 'price.post_id').andOn('price.meta_key', knex.raw('"_regular_price"'))

After

this.on('p.id', '=', 'price.post_id').andOnVal('price.meta_key', '_regular_price')

@wubzz wubzz requested a review from tgriesser August 1, 2018 09:18
@wubzz
Copy link
Member Author

wubzz commented Aug 1, 2018

Reopening, GitHub isn't updating with commits..

@wubzz wubzz closed this Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant