Add verbose option to CLI commands #2887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs test. See #2884 for a good example. |
|
I'll wait for that PR to land first and then I'll add similar tests. |
|
@avaly Aaaand it has landed :) |
avaly
force-pushed
the
feature/cli-verbose
branch
from
fc6e7ed
to
5265626
Compare
|
I've added tests for the updated code in this PR. |
kibertoad
reviewed
Dec 30, 2018
| @@ -9,12 +9,14 @@ function assertExec(cmd, desc) { | |||
| desc = desc || 'Run ' + cmd; | |||
| return new Promise((resolve, reject) => { | |||
| let stderr = ''; | |||
| console.log(`Executing: ${cmd}`); | |||
| let stdout = ''; | |||
| // console.log(`Executing: ${cmd}`); | |||
There was a problem hiding this comment.
Should this be commented out?
|
@avaly Thank you! Could you also please create a PR with documentation at https://github.com/knex/documentation ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following CLI commands get a
--verboseoption, which is used to determine whether to output the resulting log from the command action:migrate:latestmigrate:rollbackseed:run