Add withRecursive() #2889
Add withRecursive() #2889
Conversation
caseywebdev
force-pushed
the
with-recursive
branch
from
f403332
to
48d21f1
Compare
src/query/builder.js
Outdated
| @@ -45,6 +45,22 @@ function Builder(client) { | |||
| } | |||
| inherits(Builder, EventEmitter); | |||
|
|
|||
| const validateWithArgs = function(alias, statement, method) { | |||
| if (typeof alias !== 'string') { | |||
| throw new Error(method + '() first argument must be a string'); | |||
There was a problem hiding this comment.
why not use template string?
There was a problem hiding this comment.
I was simply refactoring this to be used in both with* methods. I've noticed template aren't used in most of this codebase and I assumed this was support older JS interpreters. If you're saying template strings are fine I'll update.
There was a problem hiding this comment.
Well yeah, support for older JS interpreters was a thing previously, but this year we dropped support for Node.js < 6, so it's good time to start moving towards modern JS syntax :)
| }, | ||
|
|
||
| // Helper for compiling any advanced `withRecursive` queries. | ||
| withRecursiveWrapped(alias, query) { |
There was a problem hiding this comment.
why separate this from withRecursive if it just passes same params after validation? Also, should it be public?
There was a problem hiding this comment.
I'm just mirroring the pattern established by with and withWrapped.
src/query/compiler.js
Outdated
| while (++i < withs.length) { | ||
| const stmt = withs[i]; | ||
| if (stmt.recursive) recursive = 'recursive '; |
There was a problem hiding this comment.
It's preferable to always use {}
src/query/compiler.js
Outdated
| while (++i < withs.length) { | ||
| const stmt = withs[i]; | ||
| if (stmt.recursive) recursive = 'recursive '; |
There was a problem hiding this comment.
This looks a bit redundant, you are resetting string multiple times and constructing string at this time looks kinda premature. Might be cleaner to set boolean flag instead and do something like
const withBlock = isRecursive ? : 'with recursive ' : 'with '
later on
|
Thank you for your contribution! Could you also create a PR in https://github.com/knex/documentation? |
|
Comments addressed and docs PR created knex/documentation#144 |
|
LGTM! @elhigu, what do you think? |
|
Yoo @caseywebdev good to see you man! Looks good to me, thanks for the patch! |
|
Hey Tim! Happy to help 馃憤馃徏 Thanks for the merge 馃巻 |
* Add withRecursive()
Closes #1755, an alternative to #2218
I needed
WITH RECURSIVEin a project recently so I monkey patched this in and it works great 馃憣, figured I'd help out the upstream.I noticed the other PR tried to handle the
UNION ALLautomatically for the recursive section, but in my case I actually wanted just aUNION. I think simply having this method add theRECURSIVEkeyword is the way to go since it's trivial to do the.union(...)or.unionAll(...)or whatever one needs in the query section of the.withRecursive()method.Future improvements might include a
rawversion, but I think getting this added in its simplest form is an easy win.