Fix transaction support for migrations #3084

kibertoad · 2019-03-03T23:52:46Z

kibertoad · 2019-03-03T23:54:05Z

This fix makes an assumption that we had a pretty good reason why we don't want to modify or clone transaction instances, hence we are only ensuring that they work as much as they used before. If it is OK to modify or clone transaction instances, better solution could be implemented

Latest version makes processing disabling work on transactions as well.

kibertoad · 2019-03-04T18:48:44Z

src/migrate/Migrator.js

-      this.knex = knex.withUserParams({
-        ...knex.userParams,
-      });
-      this.knex.disableProcessing();


Moved this inside operations instead to ensure correct state before each of them, regardless of how previous ones ended.

Fix transaction support for migrations

f2603c7

kibertoad requested a review from elhigu March 3, 2019 23:52

kibertoad and others added 4 commits March 4, 2019 00:57

Clarify warning

a7c0c8d

Clarify warning message

4b5170f

Simplify logic, make enabling/disabling more consistent

ef603e1

Fix tests

38d23c8

kibertoad commented Mar 4, 2019

View reviewed changes

kibertoad added 2 commits March 4, 2019 20:00

Fix test

bc449db

Reduce duplication

b51e601

kibertoad merged commit 24fcf27 into master Mar 13, 2019

kibertoad deleted the fix/3063-migrations-in-transactions branch March 13, 2019 21:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix transaction support for migrations #3084

Fix transaction support for migrations #3084

kibertoad commented Mar 3, 2019

kibertoad commented Mar 3, 2019 •

edited

kibertoad Mar 4, 2019

Fix transaction support for migrations #3084

Fix transaction support for migrations #3084

Conversation

kibertoad commented Mar 3, 2019

kibertoad commented Mar 3, 2019 • edited

kibertoad Mar 4, 2019

Choose a reason for hiding this comment

kibertoad commented Mar 3, 2019 •

edited