Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for 0.16.4-next3 release #3136

Merged
merged 2 commits into from
Apr 11, 2019
Merged

Prepare for 0.16.4-next3 release #3136

merged 2 commits into from
Apr 11, 2019

Conversation

kibertoad
Copy link
Collaborator

No description provided.

@elhigu
Copy link
Member

elhigu commented Apr 11, 2019

I've been also fixing locally tests and stuff for next release... there are some bugs still to be fixed before the release (for example mysql tests were failing when ran without sqlite tests).

So lets wait until I get those fixed for good... I was having currently problem of setting up mysql locally in a way that knex tests could be ran...

@kibertoad
Copy link
Collaborator Author

@elhigu Are these new bugs that would be regression compared to 0.16.3?

@elhigu
Copy link
Member

elhigu commented Apr 11, 2019

Yep. All tests were working on 0.16.3

@kibertoad kibertoad changed the title Prepare for 0.16.4 release Prepare for 0.16.4-next3 release Apr 11, 2019
@kibertoad
Copy link
Collaborator Author

@elhigu Merging the changes, but will wait with release for now.

@kibertoad kibertoad merged commit 286d84b into master Apr 11, 2019
@kibertoad kibertoad deleted the chore/0164 branch April 11, 2019 20:05
@elhigu
Copy link
Member

elhigu commented Apr 11, 2019

Can be released already, I can push those test related changes in later on 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants