Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

orderBy accepts QueryBuilder #3491

Merged
merged 3 commits into from Oct 24, 2019

Conversation

@HurSungYun
Copy link
Contributor

HurSungYun commented Oct 19, 2019

close #3489

@HurSungYun HurSungYun closed this Oct 19, 2019
@HurSungYun HurSungYun reopened this Oct 19, 2019
@HurSungYun

This comment has been minimized.

Copy link
Contributor Author

HurSungYun commented Oct 19, 2019

I have no idea, but integration test sometimes fails.

@kibertoad

This comment has been minimized.

Copy link
Collaborator

kibertoad commented Oct 21, 2019

@HurSungYun Could you also update TS types and documentation?

HurSungYun added 2 commits Oct 24, 2019
@kibertoad kibertoad merged commit 2d04591 into knex:master Oct 24, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kibertoad

This comment has been minimized.

Copy link
Collaborator

kibertoad commented Oct 24, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.