Fix: Added missing call to _reject in Transactor#transaction #3706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kibertoad
reviewed
Mar 6, 2020
| options, | ||
| trx | ||
| ); | ||
| trxClient.transaction(resolve, options, trx).catch(_reject); |
There was a problem hiding this comment.
in which case was this triggered? is it difficult to simulate in a test?
There was a problem hiding this comment.
Hmm... I can probably come up w/ a test case for it. I'll give it a try in a few minutes.
There was a problem hiding this comment.
Thanks for reviewing all of these, btw! Any hesitations before we merge this change?
This test case currently fails in master, but succeeds in the PR
kibertoad
approved these changes
Mar 6, 2020
|
I regret nothing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.