Rewrote Transaction#acquireConnection() methods to use async #3707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximelkin
reviewed
Mar 6, 2020
kibertoad
approved these changes
Mar 7, 2020
maximelkin
reviewed
Mar 7, 2020
| @@ -50,40 +50,28 @@ module.exports = class Oracle_Transaction extends Transaction { | |||
| return this.query(conn, `SAVEPOINT ${this.txid}`); | |||
| } | |||
|
|
|||
| acquireConnection(config, cb) { | |||
| async acquireConnection(config, cb) { | |||
| const configConnection = config && config.connection; | |||
There was a problem hiding this comment.
hm
why here configConnection retrieved, but not used in transaction?
There was a problem hiding this comment.
This is not introduced in pull request, so shouldn't be fixed right now
There was a problem hiding this comment.
Oh -- it's actually referenced towards the very bottom. It helps the Transaction decide whether or not it should release the connection.
(But, you're actually correct: even though the code is there, it doesn't actually do anything. It's either leftover from an older feature, or code that was copied unnecessarily)
maximelkin
approved these changes
Mar 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code should be functionally equivalent before and after this change. It's mostly a minor cleanup so that the next phase of refactoring will be easier.