Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first two commits should be self explanatory.
The third commit adds support for the
NULL
column constraint to the SQLite create table parser and compiler. This constraint is not mentioned in the SQLite documentation because it is a no-op. SQLite only parses it for compatibility reasons. As Knex sets this constraint on columns created with.nullable()
, we have to parse it as well.The alternativ would be to not set this constraint on nullable columns and to not parse it. Unfortunately, this would make altering columns on existing databases with nullable columns (and on those created with a raw query using the null constraint) impossible.