fix TypeScript migration stub after 0.95.0 changes #4366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 0.95.0 changed how types have to be imported when using TypeScript. This PR fixes the migration stub so new migrations are created correctly.
kibertoad
reviewed
Mar 11, 2021
|
|
||
| <% if (d.tableName) { %> | ||
| export async function up(knex: Knex): Promise<Knex.SchemaBuilder> { | ||
| return knex.schema.createTable("<%= d.tableName %>", (t: Knex.AlterTableBuilder) => { | ||
| return knex.schema.createTable("<%= d.tableName %>", (t) => { |
There was a problem hiding this comment.
Is there a reason why Knex.AlterTableBuilder was removed? Is it redundant now?
There was a problem hiding this comment.
Yes, it's redundant, TypeScript infers the type which is actually Knex.CreateTableBuilder not Knex.AlterTableBuilder.
kibertoad
approved these changes
Mar 11, 2021
This was referenced Mar 12, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release 0.95.0 changed how types have to be imported when using TypeScript. This PR fixes the migration stub so new migrations are created correctly.