Add support for file open flags for sqlite3 #4446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Boelensman1 <me@wiggerboelens.com>
Signed-off-by: Boelensman1 <me@wiggerboelens.com>
Signed-off-by: Boelensman1 <me@wiggerboelens.com>
Signed-off-by: Boelensman1 <me@wiggerboelens.com>
Signed-off-by: Boelensman1 <me@wiggerboelens.com>
Signed-off-by: Boelensman1 <me@wiggerboelens.com>
kibertoad
approved these changes
Apr 21, 2021
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this pull request it should be possible to open a shared memory database without recompiling sqlite, which has quite a lot of use cases, especially in testing. It should for example allow this solution work even if sqlite3 is not compiled with the SQLITE_USE_URI=1 flag.
I set the default mode selection to the default of node-sqlite3 so all existing code should still work.
Link to documentation PR: knex/documentation#320