-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added getDialectByNameOrAlias and converted repo to use it. #5142
Merged
kibertoad
merged 1 commit into
knex:master
from
code-ape:PR/code-ape/better-client-import
Apr 22, 2022
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
const { resolveClientNameWithAliases } = require('../util/helpers'); | ||
|
||
const dbNameToDialectLoader = Object.freeze({ | ||
'better-sqlite3': () => require('./better-sqlite3'), | ||
cockroachdb: () => require('./cockroachdb'), | ||
mssql: () => require('./mssql'), | ||
mysql: () => require('./mysql'), | ||
mysql2: () => require('./mysql2'), | ||
oracle: () => require('./oracle'), | ||
oracledb: () => require('./oracledb'), | ||
pgnative: () => require('./pgnative'), | ||
postgres: () => require('./postgres'), | ||
redshift: () => require('./redshift'), | ||
sqlite3: () => require('./sqlite3'), | ||
}); | ||
|
||
/** | ||
* Gets the Dialect object with the given client name or throw an | ||
* error if not found. | ||
* | ||
* NOTE: This is a replacement for prior practice of doing dynamic | ||
* string construction for imports of Dialect objects. | ||
*/ | ||
function getDialectByNameOrAlias(clientName) { | ||
const resolvedClientName = resolveClientNameWithAliases(clientName); | ||
const dialectLoader = dbNameToDialectLoader[resolvedClientName]; | ||
if (!dialectLoader) { | ||
throw new Error(`Invalid clientName given: ${clientName}`); | ||
} | ||
return dialectLoader(); | ||
} | ||
|
||
module.exports = { | ||
getDialectByNameOrAlias, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why freeze it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just trying to follow repo standards. I saw
Object.freeze(...)
was used for other constants. Happy to remove if preferred or change to all caps :)