Add nativeBindings option to better-sqlite3 options
#5461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kibertoad
approved these changes
Jan 23, 2023
|
Is it possible to add test for this? |
|
👍🏻 on this change because it also supports adding other |
OlivierCavadenti
approved these changes
Mar 28, 2023
There was a problem hiding this comment.
Do you have made some documentation ? As soon as it's done, I will merge this.
@beeequeue
|
I don't mind putting together a quick docs PR. |
|
PR open! knex/documentation#504. Happy to adjust the wording if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a project where I'm bundling knex and better-sqlite3 into a single file and when running it the driver can't find the included binding file which is placed adjacent to the running file.
This can be fixed by setting
new Database(path, { nativeBinding: "path/to/binding.node" })but this is currently impossible to do with knex.