Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mysql2 require breaks with Node 12 #5579

Merged
merged 2 commits into from
Jun 20, 2023
Merged

Mysql2 require breaks with Node 12 #5579

merged 2 commits into from
Jun 20, 2023

Conversation

OlivierCavadenti
Copy link
Collaborator

  • With Mysql2 > 3.2.0 require('mysql2') breaks with Node 12.
  • Add an error during mysql2 driver initialization
  • Install mysql2@3.2.0 during unit test with Node12.

Close #5578

@OlivierCavadenti
Mysql2 require breaks with Node 12
5ab201c 
- With Mysql2 > 3.2.0 require('mysql2') breaks with Node 12.
- Add an error during mysql2 driver initialization
- Install mysql2@3.2.0 during unit test with Node12.

Close knex#5578
@OlivierCavadenti
fix package name
3b296a4
@coveralls
Copy link

coveralls commented May 18, 2023 •
edited
Loading

Coverage Status

Coverage: 92.789% (-0.05%) from 92.836% when pulling 3b296a4 on OlivierCavadenti:fix/node12_mysql2 into b6d04f7 on knex:master.

@pineapplemachine
Copy link

Hi, is there anything I can do to help with this PR?

@kibertoad kibertoad merged commit 0f8bbe9 into knex:master Jun 20, 2023
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kibertoad kibertoad kibertoad approved these changes

Assignees
No one assigned
Labels
missing tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mysql2 require breaks with Node 12
4 participants
@OlivierCavadenti @coveralls @pineapplemachine @kibertoad