Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type definitions for orHavingNull and orHavingNotNull #5669

Merged
merged 6 commits into from
Nov 28, 2023
Merged

Add type definitions for orHavingNull and orHavingNotNull #5669

merged 6 commits into from
Nov 28, 2023

Conversation

pokedpeter
Copy link
Contributor

This PR is to add type definitions for orHavingNull and orHavingNotNull

This is a follow up from #5529 which added type definitions for havingNull and havingNotNull which I've used as a reference

@coveralls
Copy link

coveralls commented Nov 27, 2023 •
edited
Loading

Coverage Status

coverage: 92.799%. remained the same
when pulling c8905ef on pokedpeter:fix/or-having-types
into 57419fb on knex:master.

@kibertoad
Copy link
Collaborator

@pokedpeter linting is failing, could you please fix?

@kibertoad kibertoad merged commit a464c6a into knex:master Nov 28, 2023
23 of 30 checks passed
@kibertoad
Copy link
Collaborator

thanks!

@pokedpeter pokedpeter deleted the fix/or-having-types branch November 28, 2023 15:18
@YoutacRandS-VA YoutacRandS-VA mentioned this pull request Jun 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kibertoad kibertoad kibertoad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pokedpeter @coveralls @kibertoad