Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix andWhereNotJsonObject calling wrong function #5683

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Conversation

FKasa
Copy link
Contributor

@FKasa FKasa commented Sep 9, 2023

I have no time to write tests but the issue and the fix seem pretty obvious.
This is also my first time contributing so please review my change.
I found this bug myself while using the method at work.

@coveralls
Copy link

Coverage Status

coverage: 92.823% (+0.03%) from 92.797% when pulling 1d7ff6b on FKasa:master into 5ececd3 on knex:master.

@kibertoad kibertoad merged commit 0a29f6c into knex:master Nov 28, 2023
49 of 53 checks passed
@kibertoad
Copy link
Collaborator

thanks!

@kibertoad
Copy link
Collaborator

Released in 3.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants