Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types for TypeScript 5.4 #5747

Merged
merged 2 commits into from Nov 28, 2023
Merged

Fix types for TypeScript 5.4 #5747

merged 2 commits into from Nov 28, 2023

Conversation

gabritto
Copy link
Contributor

Compiling the file types/index.d.ts with version 5.4 of TypeScript (currently nightly) produces the following errors:

knex/types/index.d.ts(1241,50): error TS2344: Type 'ResolveTableType<TRecord, "base">' does not satisfy the constraint '{}'.
  Type 'unknown' is not assignable to type '{}'.
knex/types/index.d.ts(1256,50): error TS2344: Type 'ResolveTableType<TRecord, "base">' does not satisfy the constraint '{}'.

This was caused by this change.

This PR fixes these errors.

@kibertoad
Copy link
Collaborator

@gabritto CI for types is failing, could you please take a look?

@coveralls
Copy link

coveralls commented Nov 27, 2023

Coverage Status

coverage: 92.778%. remained the same
when pulling bf01fbf on gabritto:fix-5.4
into 1d7707e on knex:master.

@kibertoad
Copy link
Collaborator

Thanks a lot!

@kibertoad kibertoad merged commit 14b2b6d into knex:master Nov 28, 2023
25 of 29 checks passed
@gabritto gabritto deleted the fix-5.4 branch November 28, 2023 02:34
@gabritto
Copy link
Contributor Author

gabritto commented Dec 7, 2023

@kibertoad what's the release schedule for knex? I'd like to know when there will be a release with the new index.d.ts, just so I know when I can remove it from the expected list of failures we have over on DefinitelyTyped.

@kibertoad
Copy link
Collaborator

@gabritto I can probably cut a new one right now!

@kibertoad
Copy link
Collaborator

Released in 3.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants