Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.d.ts #5767

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update index.d.ts #5767

wants to merge 1 commit into from

Conversation

hzgotb
Copy link

@hzgotb hzgotb commented Dec 9, 2023

for below example will tell me 'this' implicitly has type 'any' because it does not have a type annotation.ts(2683)

const b = knex.select().from(function () {
        return this.select().as('a');
    }).toQuery();

fix missing type this in from
@coveralls
Copy link

Coverage Status

coverage: 92.787%. remained the same
when pulling d741631 on hzgotb:patch-1
into 4ca3dd5 on knex:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants